Cppcheck - HTML report - digiKam-master-rev-70b072e127

# Cppcheck report - digiKam-master-rev-70b072e127: ../../core/libs/dplugins/core/dplugineditor.cpp

      1
      2
      3
      4
      5
      6
      7
      8
      9
     10
     11
     12
     13
     14
     15
     16
     17
     18
     19
     20
     21
     22
     23
     24
     25
     26
     27
     28
     29
     30
     31
     32
     33
     34
     35
     36
     37
     38
     39
     40
     41
     42
     43
     44
     45
     46
     47
     48
     49
     50
     51
     52
     53
     54
     55
     56
     57
     58
     59
     60
     61
     62
     63
     64
     65
     66
     67
     68
     69
     70
     71
     72
     73
     74
     75
     76
     77
     78
     79
     80
     81
     82
     83
     84
     85
     86
     87
     88
     89
     90
     91
     92
     93
     94
     95
     96
     97
     98
     99
    100
    101
    102
    103
    104
    105
    106
    107
    108
    109
    110
    111
    112
    113
    114
    115
    116
    117
    118
    119
    120
    121
    122
    123
    124
    125
    126
    127
    128
    129
    130
    131
    132
    133
    134
    135
    136
    137
    138
    139
    140
    141
    142
    143
    144
    145
    146
    147
    148
    149
    150
    151
    152
    153
    154
    155
    156
    157
    158
    159
    160
    161
    162
    163
    164
    165
    166
    167
    168
    169
    170
    171
    172
    /* ============================================================
     *
     * This file is a part of digiKam project
     * https://www.digikam.org
     *
     * Date        : 2018-07-30
     * Description : Image Editor digiKam plugin definition.
     *
     * SPDX-FileCopyrightText: 2018-2026 by Gilles Caulier <caulier dot gilles at gmail dot com>
     *
     * SPDX-License-Identifier: GPL-2.0-or-later
     *
     * ============================================================ */

    #include "dplugineditor.h"

    // Qt includes

    #include <QApplication>

    // Local includes

    #include "digikam_version.h"
    #include "digikam_debug.h"
    #include "dxmlguiwindow.h"

    namespace Digikam
    {

    class Q_DECL_HIDDEN DPluginEditor::Private
    {
    public:

        Private() = default;

        QList<DPluginAction*> actions;
    };

    DPluginEditor::DPluginEditor(QObject* const parent)
        : DPlugin(parent),
          d      (new Private)
    {
    }

    DPluginEditor::~DPluginEditor()
    {
        delete d;
    }

    DInfoInterface* DPluginEditor::infoIface(QObject* const ac) const
    {
        DPluginAction* const pac = dynamic_cast<DPluginAction*>(ac);

        if (pac)
        {
            DXmlGuiWindow* const gui = dynamic_cast<DXmlGuiWindow*>(pac->parent());

            if (gui)
            {
                return gui->infoIface(pac);
            }

            DInfoInterface* const iface = dynamic_cast<DInfoInterface*>(pac->parent());

            if (iface)
            {
                return iface;
            }
        }

        return nullptr;
    }

    int DPluginEditor::count() const
    {
        int count       = 0;
        const QObject* parent = nullptr;

        for (DPluginAction* const ac : std::as_const(d->actions))
        {
            if (ac)
            {
                // NOTE: we will return the count of actions registered with the same parents,
                //       as each parent registered the same list of actions through setup().

                if      (!count)
                {
                    parent = ac->parent(),
                    ++count;
                }
                else if (ac->parent() == parent)
                {
                    ++count;
                }
            }
        }

        return count;
    }

    void DPluginEditor::setVisible(bool b)
    {
        for (DPluginAction* const ac : std::as_const(d->actions))
        {
            if (ac)
            {
                ac->setVisible(b);
            }
        }
    }

    QList<DPluginAction*> DPluginEditor::actions(QObject* const parent) const<--- Either there is a missing override/final keyword, or the parameter 'parent' can be declared as pointer to const
    {
        QList<DPluginAction*> list;

        for (DPluginAction* const ac : std::as_const(d->actions))
        {
            if (ac && (ac->parent() == parent))
            {
                list << ac;
            }
        }

        std::sort(list.begin(), list.end(), DPluginAction::pluginActionLessThan);

        return list;
    }

    DPluginAction* DPluginEditor::findActionByName(const QString& name, QObject* const parent) const
    {
        const auto acs = actions(parent);

        for (DPluginAction* const ac : acs)
        {
            if (ac && (ac->objectName() == name))
            {    // cppcheck-suppress useStlAlgorithm
                return ac;
            }
        }

        return nullptr;
    }

    void DPluginEditor::addAction(DPluginAction* const ac)
    {
        ac->setProperty("DPluginIId",      iid());
        ac->setProperty("DPluginIfaceIId", ifaceIid());
        d->actions.append(ac);
    }

    QStringList DPluginEditor::categories() const
    {
        QStringList list;

        for (const DPluginAction* const ac : std::as_const(d->actions))
        {
            QString cat = ac->actionCategoryToString();

            if (!list.contains(cat))
            {
                list << cat;
            }
        }

        list.sort();

        return list;
    }

    } // namespace Digikam

    #include "moc_dplugineditor.cpp"