Cppcheck - HTML report - digiKam-nl-search-more-criteria-rev-e2466e0973

# Cppcheck report - digiKam-nl-search-more-criteria-rev-e2466e0973: ../../core/utilities/geolocation/engine/geodata/data/GeoDataSimpleField.cpp

      1
      2
      3
      4
      5
      6
      7
      8
      9
     10
     11
     12
     13
     14
     15
     16
     17
     18
     19
     20
     21
     22
     23
     24
     25
     26
     27
     28
     29
     30
     31
     32
     33
     34
     35
     36
     37
     38
     39
     40
     41
     42
     43
     44
     45
     46
     47
     48
     49
     50
     51
     52
     53
     54
     55
     56
     57
     58
     59
     60
     61
     62
     63
     64
     65
     66
     67
     68
     69
     70
     71
     72
     73
     74
     75
     76
     77
     78
     79
     80
     81
     82
     83
     84
     85
     86
     87
     88
     89
     90
     91
     92
     93
     94
     95
     96
     97
     98
     99
    100
    101
    102
    103
    104
    105
    106
    107
    108
    109
    110
    111
    112
    113
    114
    115
    116
    117
    118
    119
    120
    121
    122
    /* ============================================================
     *
     * This file is a part of digiKam project
     * https://www.digikam.org
     *
     * Date        : 2023-05-15
     * Description : geolocation engine based on Marble.
     *               (c) 2007-2022 Marble Team
     *               https://invent.kde.org/education/marble/-/raw/master/data/credits_authors.html
     *
     * SPDX-FileCopyrightText: 2023-2026 by Gilles Caulier <caulier dot gilles at gmail dot com>
     *
     * SPDX-License-Identifier: LGPL-2.1-or-later
     *
     * ============================================================ */

    #include "GeoDataSimpleField.h"

    // Qt includes

    #include <QDataStream>
    #include <QString>

    // Local includes

    #include "GeoDataTypes.h"

    namespace Marble
    {

    class Q_DECL_HIDDEN GeoDataSimpleFieldPrivate
    {
    public:

        QString                             m_name;
        GeoDataSimpleField::SimpleFieldType m_type;<--- Member variable 'GeoDataSimpleFieldPrivate::m_type' has no initializer. [+]Member variable 'GeoDataSimpleFieldPrivate::m_type' has no initializer. Member variables of native types, pointers, or references are left uninitialized when the class is instantiated. That may cause bugs or undefined behavior.
        QString                             m_displayName;
    };

    GeoDataSimpleField::GeoDataSimpleField()
        : GeoNode(),
          d(new GeoDataSimpleFieldPrivate)
    {
    }

    GeoDataSimpleField::GeoDataSimpleField(const GeoDataSimpleField& other)
        : GeoNode(),
          d(new GeoDataSimpleFieldPrivate(*other.d))
    {
    }

    bool GeoDataSimpleField::operator==(const GeoDataSimpleField& other) const
    {
        return d->m_name == other.d->m_name &&
               d->m_type == other.d->m_type &&
               d->m_displayName == other.d->m_displayName;
    }

    bool GeoDataSimpleField::operator!=(const GeoDataSimpleField& other) const
    {
        return !this->operator==(other);
    }

    GeoDataSimpleField::~GeoDataSimpleField()
    {
        delete d;
    }

    GeoDataSimpleField::SimpleFieldType GeoDataSimpleField::type() const
    {
        return d->m_type;
    }

    void GeoDataSimpleField::setType(SimpleFieldType type)<--- Shadow argument
    {
        d->m_type = type;
    }

    QString GeoDataSimpleField::name() const
    {
        return d->m_name;
    }

    void GeoDataSimpleField::setName(const QString& value)
    {
        d->m_name = value;
    }

    QString GeoDataSimpleField::displayName() const
    {
        return d->m_displayName;
    }

    void GeoDataSimpleField::setDisplayName(const QString& displayName)<--- Shadow argument
    {
        d->m_displayName = displayName;
    }

    GeoDataSimpleField& GeoDataSimpleField::operator=(const GeoDataSimpleField& other)
    {
        *d = *other.d;
        return *this;
    }

    const char* GeoDataSimpleField::nodeType() const
    {
        return GeoDataTypes::GeoDataSimpleFieldType;
    }

    void GeoDataSimpleField::pack(QDataStream& stream) const
    {
        stream << d->m_name;
        stream << d->m_displayName;
    }

    void GeoDataSimpleField::unpack(QDataStream& stream)
    {
        stream >> d->m_name;
        stream >> d->m_displayName;
    }

    } // namespace Marble