Cppcheck - HTML report - digiKam-nl-search-more-criteria-rev-e2466e0973

# Cppcheck report - digiKam-nl-search-more-criteria-rev-e2466e0973: ../../core/utilities/import/dialogs/camerafolderdialog.cpp

      1
      2
      3
      4
      5
      6
      7
      8
      9
     10
     11
     12
     13
     14
     15
     16
     17
     18
     19
     20
     21
     22
     23
     24
     25
     26
     27
     28
     29
     30
     31
     32
     33
     34
     35
     36
     37
     38
     39
     40
     41
     42
     43
     44
     45
     46
     47
     48
     49
     50
     51
     52
     53
     54
     55
     56
     57
     58
     59
     60
     61
     62
     63
     64
     65
     66
     67
     68
     69
     70
     71
     72
     73
     74
     75
     76
     77
     78
     79
     80
     81
     82
     83
     84
     85
     86
     87
     88
     89
     90
     91
     92
     93
     94
     95
     96
     97
     98
     99
    100
    101
    102
    103
    104
    105
    106
    107
    108
    109
    110
    111
    112
    113
    114
    115
    116
    117
    118
    119
    120
    121
    122
    123
    124
    125
    126
    127
    128
    129
    130
    131
    132
    133
    134
    135
    136
    137
    138
    139
    140
    141
    142
    143
    144
    145
    146
    147
    148
    149
    150
    151
    152
    153
    154
    155
    156
    157
    158
    159
    160
    161
    162
    163
    164
    165
    166
    167
    168
    169
    170
    171
    172
    173
    174
    175
    176
    177
    178
    179
    180
    181
    182
    183
    184
    185
    186
    187
    188
    189
    190
    191
    192
    193
    194
    195
    196
    197
    198
    199
    200
    201
    202
    203
    204
    205
    /* ============================================================
     *
     * This file is a part of digiKam project
     * https://www.digikam.org
     *
     * Date        : 2006-07-24
     * Description : a dialog to select a camera folders.
     *
     * SPDX-FileCopyrightText: 2006-2026 by Gilles Caulier <caulier dot gilles at gmail dot com>
     *
     * SPDX-License-Identifier: GPL-2.0-or-later
     *
     * ============================================================ */

    #include "camerafolderdialog.h"

    // Qt includes

    #include <QLabel>
    #include <QFrame>
    #include <QGridLayout>
    #include <QStandardPaths>
    #include <QApplication>
    #include <QStyle>
    #include <QDialogButtonBox>
    #include <QVBoxLayout>
    #include <QPushButton>

    // KDE includes

    #include <klocalizedstring.h>

    // Local includes

    #include "digikam_debug.h"
    #include "digikam_globals.h"
    #include "camerafolderitem.h"
    #include "camerafolderview.h"
    #include "dxmlguiwindow.h"

    namespace Digikam
    {

    class Q_DECL_HIDDEN CameraFolderDialog::Private
    {
    public:

        Private() = default;

    public:

        QString           rootPath;
        QDialogButtonBox* buttons       = nullptr;

        CameraFolderView* folderView    = nullptr;
    };

    CameraFolderDialog::CameraFolderDialog(QWidget* const parent, const QMap<QString, int>& map,
                                           const QString& cameraName, const QString& rootPath)
        : QDialog(parent),
          d      (new Private)
    {
        setModal(true);
        setWindowTitle(i18nc("@title:window %1: name of the camera", "%1 - Select Camera Folder", cameraName));

        const int spacing       = layoutSpacing();

        d->buttons              = new QDialogButtonBox(QDialogButtonBox::Help | QDialogButtonBox::Ok | QDialogButtonBox::Cancel, this);
        d->buttons->button(QDialogButtonBox::Ok)->setDefault(true);
        d->buttons->button(QDialogButtonBox::Ok)->setEnabled(false);

        d->rootPath             = rootPath;
        QFrame* const page      = new QFrame(this);

        QGridLayout* const grid = new QGridLayout(page);
        d->folderView           = new CameraFolderView(page);
        QLabel* const logo      = new QLabel(page);
        QLabel* const message   = new QLabel(page);

        logo->setPixmap(QIcon::fromTheme(QLatin1String("digikam")).pixmap(QSize(48,48)));

        message->setText(i18nc("@info", "Please select the camera folder "
                                        "where you want to upload the images."));
        message->setWordWrap(true);

        grid->addWidget(logo,          0, 0, 1, 1);
        grid->addWidget(message,       1, 0, 1, 1);
        grid->addWidget(d->folderView, 0, 1, 3, 1);
        grid->setColumnStretch(0, 2);
        grid->setColumnStretch(1, 10);
        grid->setRowStretch(2, 10);
        grid->setContentsMargins(spacing, spacing, spacing, spacing);
        grid->setSpacing(spacing);

        QVBoxLayout* const vbx = new QVBoxLayout(this);
        vbx->addWidget(page);
        vbx->addWidget(d->buttons);
        setLayout(vbx);

        d->folderView->addVirtualFolder(cameraName);
        d->folderView->addRootFolder(QLatin1String("/"));

        for (QMap<QString, int>::const_iterator it = map.constBegin() ;
             it != map.constEnd() ; ++it)
        {
            QString folder(it.key());

            if (folder != QLatin1String("/"))
            {
                if (folder.startsWith(rootPath) && rootPath != QLatin1String("/"))
                {
                    folder.remove(0, rootPath.length());
                }

                QString path(QLatin1Char('/'));
                const auto subs = folder.split(QLatin1Char('/'), Qt::SkipEmptyParts);

                for (const QString& sub : subs)
                {
                    qCDebug(DIGIKAM_IMPORTUI_LOG) << "Camera folder:" << path << "Subfolder:" << sub;
                    d->folderView->addFolder(path, sub, it.value());
                    path += sub + QLatin1Char('/');
                }
            }
        }

        connect(d->folderView, SIGNAL(signalFolderChanged(CameraFolderItem*)),
                this, SLOT(slotFolderPathSelectionChanged(CameraFolderItem*)));

        connect(d->buttons->button(QDialogButtonBox::Ok), SIGNAL(clicked()),
                this, SLOT(accept()));

        connect(d->buttons->button(QDialogButtonBox::Cancel), SIGNAL(clicked()),
                this, SLOT(reject()));

        connect(d->buttons->button(QDialogButtonBox::Help), SIGNAL(clicked()),
                this, SLOT(slotHelp()));

        adjustSize();

        // make sure the ok button is properly set up

        d->buttons->button(QDialogButtonBox::Ok)->setEnabled(d->folderView->currentItem() != nullptr);
    }

    CameraFolderDialog::~CameraFolderDialog()
    {
        delete d;
    }

    QString CameraFolderDialog::selectedFolderPath() const
    {
        QTreeWidgetItem* const item = d->folderView->currentItem();

        if (!item)
        {
            return QString();
        }

        const CameraFolderItem* const folderItem = dynamic_cast<CameraFolderItem*>(item);

        if (!folderItem)
        {
            return QString();
        }

        if (folderItem->isVirtualFolder())
        {
            return QString(d->rootPath);
        }

        // Case of Gphoto2 cameras. No need to duplicate root '/'.

        if (d->rootPath == QLatin1String("/"))
        {
            return(folderItem->folderPath());
        }

        return (d->rootPath + folderItem->folderPath());
    }

    void CameraFolderDialog::slotFolderPathSelectionChanged(CameraFolderItem* item)<--- Either there is a missing override/final keyword, or the parameter 'item' can be declared as pointer to const
    {
        if (item)
        {
            d->buttons->button(QDialogButtonBox::Ok)->setEnabled(true);
            qCDebug(DIGIKAM_IMPORTUI_LOG) << "Camera folder path: " << selectedFolderPath();
        }
        else
        {
            d->buttons->button(QDialogButtonBox::Ok)->setEnabled(false);
        }
    }

    void CameraFolderDialog::slotHelp()
    {
        openOnlineDocumentation(QLatin1String("import_tools"),
                                QLatin1String("camera_import"),
                                QLatin1String("camera-upload"));
    }

    } // namespace Digikam

    #include "moc_camerafolderdialog.cpp"